Lee-W commented on code in PR #44686:
URL: https://github.com/apache/airflow/pull/44686#discussion_r1870998954
##########
providers/src/airflow/providers/common/io/assets/file.py:
##########
@@ -19,13 +19,9 @@
import urllib.parse
from typing import TYPE_CHECKING
-from packaging.version import Version
+from airflow.providers.common.io import PROVIDERS_COMMON_IO_AIRFLOW_IS_3_0_PLUS
-from airflow import __version__ as AIRFLOW_VERSION
-
-# TODO: Remove version check block after bumping common provider to 1.3.0
Review Comment:
This is probably still needed
##########
providers/src/airflow/providers/google/assets/gcs.py:
##########
@@ -26,17 +27,10 @@
from airflow.providers.common.compat.assets import Asset
from airflow.providers.common.compat.openlineage.facet import Dataset as
OpenLineageDataset
else:
- # TODO: Remove this try-exception block after bumping common provider to
1.3.0
Review Comment:
This TODO is probably still needed
##########
providers/src/airflow/providers/amazon/aws/assets/s3.py:
##########
@@ -28,17 +29,10 @@
Dataset as OpenLineageDataset,
)
else:
- # TODO: Remove this try-exception block after bumping common provider to
1.3.0
- # This is due to common provider AssetDetails import error handling
Review Comment:
This is probably still needed
##########
providers/src/airflow/providers/openlineage/utils/utils.py:
##########
@@ -74,17 +78,14 @@
from airflow.providers.common.compat.assets import Asset
from airflow.utils.state import DagRunState, TaskInstanceState
else:
- # TODO: Remove this try-exception block after bumping common provider to
1.3.0
Review Comment:
This TODO is probably still needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
