potiuk commented on code in PR #44686:
URL: https://github.com/apache/airflow/pull/44686#discussion_r1871184663
##########
providers/src/airflow/providers/amazon/aws/assets/s3.py:
##########
@@ -28,17 +29,10 @@
Dataset as OpenLineageDataset,
)
else:
- # TODO: Remove this try-exception block after bumping common provider to
1.3.0
- # This is due to common provider AssetDetails import error handling
Review Comment:
Basically - we do not need any relation with common-compat when we write a
conditional (`if airflow version`) code in providers - which was really the
main complaint (and rightfully so) of @dstandish.
So common-compat should only be used when we have some "real" code in
airflow that we need to backport there. Version code is easy to maintain and
generate, so it makes sense to generate it in `__init__.py` automatically in
those providers that need it (which is precisely what this PR does).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
