potiuk commented on code in PR #44686:
URL: https://github.com/apache/airflow/pull/44686#discussion_r1871021270
##########
providers/src/airflow/providers/amazon/aws/assets/s3.py:
##########
@@ -28,17 +29,10 @@
Dataset as OpenLineageDataset,
)
else:
- # TODO: Remove this try-exception block after bumping common provider to
1.3.0
- # This is due to common provider AssetDetails import error handling
Review Comment:
Not really. This is a nice by-product of this change.
1) We are not importing from common provider any more, so we will not be
bumping it here.
2) When we update min version of provider for airflow, we will automatically
fail in the places where the constants were used and they got removed.
For example - when in the future we will have min_airflow_version = 2.9.0 -
we will change the template to remove all _2_9_0_PLUS generated constants. And
all the places where those constants were used will automatically fail because
the imports will fail (and we will have to fix it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
