potiuk commented on code in PR #44686: URL: https://github.com/apache/airflow/pull/44686#discussion_r1871507576
########## providers/src/airflow/providers/common/compat/lineage/hook.py: ########## @@ -16,7 +16,10 @@ # under the License. from __future__ import annotations -from airflow.providers.common.compat import AIRFLOW_V_2_10_PLUS, AIRFLOW_V_3_0_PLUS +from airflow.providers.common.compat import ( + PROVIDERS_COMMON_COMPAT_AIRFLOW_IS_2_10_PLUS, + PROVIDERS_COMMON_COMPAT_AIRFLOW_IS_3_0_PLUS, Review Comment: Many times (and that already happened) people just do "Ctrl-Shift-O" and constants are imported from wrong place and reviewers are missing it (happened already) - renaming those constants makes it much more difficult to make the mistake (for example importing same constant from different provider) when you are reviewing the code. That's the root cause that already happened in the past and this PR already solved one of those that were left and missed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
