potiuk commented on code in PR #44686:
URL: https://github.com/apache/airflow/pull/44686#discussion_r1871492220
##########
providers/src/airflow/providers/amazon/aws/assets/s3.py:
##########
@@ -28,17 +29,10 @@
Dataset as OpenLineageDataset,
)
else:
- # TODO: Remove this try-exception block after bumping common provider to
1.3.0
- # This is due to common provider AssetDetails import error handling
Review Comment:
Ah.... I see that was double-compatibility check - but this is not really
needed - instead (see the latest push) we should bump the version of compat
provider dependency in AWS (and the compat provider version in provider.yaml)
and it should **generally** work as expected - without having to add two
compatiblity checks - one in amazon provider and another in the compat
provider.
I updated it in this way and let's see if it works out-of-the-box.
This is one of the few exceptions where we can bump version of compat
provider when we add a new feature to it - then in the dependent provider you
bump the minimum version, and since they are going to be released together in
the next wave of providers things will work just fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
