potiuk commented on PR #44686: URL: https://github.com/apache/airflow/pull/44686#issuecomment-2520541705
Generally when you come to checking airflow version and having compat code we have two choices: * rely on compat provider -> and then maintain dependencies and add dependency to the compat providers * not DRY version code in each provider This is a variant of not DRY version code in Airflow provider - that people tried to update in a few places over last few weeks and made at least 4 mistakes - like overwriting __init__.py (where it makes most sense to keep it), adding constans in different packages, importing constants from different packages, importing constants from test code instead of providers. I mean - yes, it's not **simple** code - but it addreses at least 4 problems I know that happened recently in the way that all this is automated so that those mistakes are impossible or very difficult to make. What's wrong with that? Would you prefer to keep release manager fixing mistakes of those people at the relaase time (happened already once https://github.com/apache/airflow/pull/44011#discussion_r1841786333 and was supposed to happen again: https://github.com/apache/airflow/pull/43773#discussion_r1867636526 None of the solution proposed in the last two day addressed those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
