ashb commented on code in PR #44686: URL: https://github.com/apache/airflow/pull/44686#discussion_r1872941019
########## providers/src/airflow/providers/common/compat/lineage/hook.py: ########## @@ -16,7 +16,10 @@ # under the License. from __future__ import annotations -from airflow.providers.common.compat import AIRFLOW_V_2_10_PLUS, AIRFLOW_V_3_0_PLUS +from airflow.providers.common.compat import ( + PROVIDERS_COMMON_COMPAT_AIRFLOW_IS_2_10_PLUS, + PROVIDERS_COMMON_COMPAT_AIRFLOW_IS_3_0_PLUS, Review Comment: > That's the root cause that already happened in the past and this PR already solved one of those that were left and missed The issue that started this change seemed to be about manual changes to generated files, and preventing that is un-contentious. But it them seemed to transform into "lets build a load of scaffolding to be unified about version checks". That's the part I have problems with as this solution makes everything incrementally more complex, each individual change is "yeah okay, slightly complex" but in aggregate all this pre-commit+autogenerated code+magic leads to a hugely complex system. That said listening to an episode of Talk Python To Me this morning https://import-linter.readthedocs.io/en/stable/index.html came up. I'm trying this quickly to see if we can make it not allow imports from a provider it doesn't list as a dep on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
