potiuk commented on PR #44686: URL: https://github.com/apache/airflow/pull/44686#issuecomment-2525298095
OK. I reworked it to follow the suggestion by @ashb (i.e. using `ruff analyze graph`. I managed to work out to work it out to catch both `other provider` imports and `tests_common` wrong import - and added documentation explaining why we are doing it and what the contributors should do, when they want to add version check support to their provider: Example pre-commit errors: When you import from tests_common:  When you import from another provider:  The change is way bigger than the original one, because I had to extract the `version` commands from `tests_utils.compat` to `version_compat` - because `ruff analyze graph` produces output on a file level, and that was the easy way to check - if `version_compat` is being imported, it should be from the same provider. Lookig forward to feedback and comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
