jscheffl commented on code in PR #45259: URL: https://github.com/apache/airflow/pull/45259#discussion_r1906082730
########## airflow/new_provider.yaml.schema.json: ########## Review Comment: I would recommend not calling this "new" but rather rename the existing one to "legacy_structure" or so. ########## providers/airbyte/pyproject.toml: ########## @@ -0,0 +1,73 @@ + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# NOTE! THIS FILE IS AUTOMATICALLY GENERATED AND WILL BE OVERWRITTEN! + +# IF YOU WANT TO MODIFY THIS FILE, YOU SHOULD MODIFY THE TEMPLATE +# `pyproject_TEMPLATE.toml.jinja2` IN the `dev/breeze/src/airflow_breeze/templates` DIRECTORY +[build-system] +requires = ["flit_core==3.10.1"] +build-backend = "flit_core.buildapi" + +[project] +name = "apache-airflow-providers-airbyte" +version = "5.0.0" +description = "Provider package apache-airflow-providers-airbyte for Apache Airflow" +readme = "README.rst" +authors = [ + {name="Apache Software Foundation", email="[email protected]"}, +] +maintainers = [ + {name="Apache Software Foundation", email="[email protected]"}, +] +keywords = [ "airflow-provider", "airbyte", "airflow", "integration" ] +classifiers = [ + "Development Status :: 5 - Production/Stable", + "Environment :: Console", + "Environment :: Web Environment", + "Intended Audience :: Developers", + "Intended Audience :: System Administrators", + "Framework :: Apache Airflow", + "Framework :: Apache Airflow :: Provider", + "License :: OSI Approved :: Apache Software License", + "Programming Language :: Python :: 3.9", + "Programming Language :: Python :: 3.10", + "Programming Language :: Python :: 3.11", + "Programming Language :: Python :: 3.12", + "Topic :: System :: Monitoring", +] +requires-python = "~=3.9" +dependencies = [ + "apache-airflow>=2.9.0", + "airbyte-api>=0.52.0", +] Review Comment: How is the dependency generated when is it not contained in provider.yaml anymore?!? ########## providers/src/airflow/providers/edge/provider.yaml: ########## @@ -14,8 +14,6 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. - -# yaml-language-server: $schema=../../provider.yaml.schema.json Review Comment: Ups, good catch... VSCode user revealed :-D - seems the path is from the structure before providers were extracted from airflow folder. Thanks for the cleanup! ########## airflow/models/abstractoperator.py: ########## @@ -44,7 +44,7 @@ if TYPE_CHECKING: from collections.abc import Mapping - import jinja2 # Slow import. + import jinja2 # Slow imports. Review Comment: I'd propose to make this to another PR. Seems unrelated. ########## airflow/new_provider.yaml.schema.json: ########## Review Comment: Why actually do we need a new schema? I just saw the diff is mainly coming from removed dependencies... but where are these now defined? (if pyproject.toml is generated...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
