potiuk commented on code in PR #45259: URL: https://github.com/apache/airflow/pull/45259#discussion_r1907731701
########## airflow/new_provider.yaml.schema.json: ########## Review Comment: Good idea (to use different naming here) . Yes. It's all about dependencies. PyProject toml is generated ***with the exception** of dependencies. What we do - we read the dependencies from `pyproject.toml` first -> and then generate the pyproject.toml again with all the updated things (such as version of the provider). This is for example to accomodate the links to the provider's URLs - directly linking to the docs of the provider in the right version - that's why `pyproject.toml` needs to be regenerated anyway. And dependencies is really the only things that we are expected to be maintained by contributors, so it actually makes sense to let them update directly in `pyproject.toml` - rather than have another source of truth. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
