dstandish commented on code in PR #45537:
URL: https://github.com/apache/airflow/pull/45537#discussion_r1910690535
##########
task_sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -286,13 +286,13 @@ def exit(n: int) -> NoReturn:
@attrs.define()
class WatchedSubprocess:
- id: UUID
+ id: UUID | None
pid: int
stdin: BinaryIO
"""The handle connected to stdin of the child process"""
- client: Client
+ client: Client | None
Review Comment:
no client is provided by dag processor it was explicitly given _none_; so
clearly the base class is ok with that. it's only for task execution scenario
that it is used and depended on. that's why the type checking asserts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]