dstandish commented on code in PR #45537:
URL: https://github.com/apache/airflow/pull/45537#discussion_r1910710031
##########
task_sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -319,14 +319,17 @@ class WatchedSubprocess:
@classmethod
def start(
cls,
- path: str | os.PathLike[str],
- what: TaskInstance,
- client: Client,
+ id: UUID | None,
Review Comment:
ok so, here's what's going on here.
previously `id` was not an explicit param. it was part of "constructor
kwargs" and it was sometimes provided and sometimes no. it was provided by dag
processor but _not_ for task execution. for task execution, it was grabbed
from `ti.id` _inside_ this function. here, i add it as an explicit argument
and it is thus always supplied. and we can make it not None now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]