dstandish commented on code in PR #45537: URL: https://github.com/apache/airflow/pull/45537#discussion_r1910714016
########## task_sdk/src/airflow/sdk/execution_time/supervisor.py: ########## @@ -286,13 +286,13 @@ def exit(n: int) -> NoReturn: @attrs.define() class WatchedSubprocess: - id: UUID + id: UUID | None Review Comment: client was None for dag processing; id was not None for either of them, but it was not an explicit argument which was confusing. there's no need for it to not be an explicit param. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
