pierrejeambrun commented on code in PR #45977:
URL: https://github.com/apache/airflow/pull/45977#discussion_r1928391228


##########
airflow/ui/src/queries/usePatchDagRun.ts:
##########
@@ -45,7 +46,11 @@ export const usePatchDagRun = ({
   const queryClient = useQueryClient();
 
   const onSuccessFn = async () => {
-    const queryKeys = [UseDagRunServiceGetDagRunKeyFn({ dagId, dagRunId }), 
[useDagRunServiceGetDagRunsKey]];
+    const queryKeys = [
+      UseDagRunServiceGetDagRunKeyFn({ dagId, dagRunId }),
+      [useDagRunServiceGetDagRunsKey],
+      [useTaskInstanceServiceGetTaskInstancesKey],

Review Comment:
   Or maybe it's a little bit more tricky because actually depends on 
"past/future" can impact tasks outside of the considered dagrun. And therefore 
we need to invalidate all 'list tasks'. cf `def get_run_ids`.



##########
airflow/ui/src/queries/usePatchDagRun.ts:
##########
@@ -45,7 +46,11 @@ export const usePatchDagRun = ({
   const queryClient = useQueryClient();
 
   const onSuccessFn = async () => {
-    const queryKeys = [UseDagRunServiceGetDagRunKeyFn({ dagId, dagRunId }), 
[useDagRunServiceGetDagRunsKey]];
+    const queryKeys = [
+      UseDagRunServiceGetDagRunKeyFn({ dagId, dagRunId }),
+      [useDagRunServiceGetDagRunsKey],
+      [useTaskInstanceServiceGetTaskInstancesKey],

Review Comment:
   Or maybe it's a little bit more tricky because depends on "past/future" can 
impact tasks outside of the considered dagrun. And therefore we need to 
invalidate all 'list tasks'. cf `def get_run_ids`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to