tirkarthi commented on code in PR #45977:
URL: https://github.com/apache/airflow/pull/45977#discussion_r1929021262
##########
airflow/ui/src/queries/usePatchDagRun.ts:
##########
@@ -45,7 +46,11 @@ export const usePatchDagRun = ({
const queryClient = useQueryClient();
const onSuccessFn = async () => {
- const queryKeys = [UseDagRunServiceGetDagRunKeyFn({ dagId, dagRunId }),
[useDagRunServiceGetDagRunsKey]];
+ const queryKeys = [
+ UseDagRunServiceGetDagRunKeyFn({ dagId, dagRunId }),
+ [useDagRunServiceGetDagRunsKey],
+ [useTaskInstanceServiceGetTaskInstancesKey],
Review Comment:
I tried `UseTaskInstanceServiceGetTaskInstancesKeyFn({ dagId, dagRunId})`
and it didn't work. From what I can understand the query for task instances in
the dag run page includes limit, offset and order_by which also has to be
passed to the fn to form the correct query key. If the user has filters for
state and task id search then they also have to be included to form the right
key. Please correct me if I am wrong on this. Below seems to work.
```
UseTaskInstanceServiceGetTaskInstancesKeyFn({ dagId, dagRunId, limit: 15,
offset:0, orderBy: "-start_date" })
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
