vincbeck commented on code in PR #46684:
URL: https://github.com/apache/airflow/pull/46684#discussion_r1952999445
##########
providers/amazon/src/airflow/providers/amazon/aws/operators/dms.py:
##########
@@ -493,10 +493,6 @@ def execute(self, context: Context) -> None:
Filters=[{"Name": "replication-config-arn", "Values":
[self.replication_config_arn]}],
WaiterConfig={"Delay": self.waiter_delay, "MaxAttempts":
self.waiter_max_attempts},
)
- self.hook.get_waiter("replication_deprovisioned").wait(
- Filters=[{"Name": "replication-config-arn", "Values":
[self.replication_config_arn]}],
- WaiterConfig={"Delay": self.waiter_delay, "MaxAttempts":
self.waiter_max_attempts},
Review Comment:
Well, yes and no. I updated the waiter `replication_terminal_status` to
include the states `created` and `deprovisioned`. I did that because these
states are terminal status so it makes sense to include it in
`replication_terminal_status`. The waiter `replication_deprovisioned` is
waiting for `deprovisioned` state so it is longer needed to use this waiter
since `replication_terminal_status` already take care of it. tldr; The operator
`DmsDeleteReplicationConfigOperator` behavior has not changed so there is no
consequence for users. The only change for users is if they use the waiter
`replication_terminal_status` in their own operators, but this is more a bug
fix than a user facing change. I'll add that information in the commit message
because I think you are right and it is worth mentioning it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
