eladkal commented on code in PR #46684:
URL: https://github.com/apache/airflow/pull/46684#discussion_r1953016557
##########
providers/amazon/src/airflow/providers/amazon/aws/operators/dms.py:
##########
@@ -493,10 +493,6 @@ def execute(self, context: Context) -> None:
Filters=[{"Name": "replication-config-arn", "Values":
[self.replication_config_arn]}],
WaiterConfig={"Delay": self.waiter_delay, "MaxAttempts":
self.waiter_max_attempts},
)
- self.hook.get_waiter("replication_deprovisioned").wait(
- Filters=[{"Name": "replication-config-arn", "Values":
[self.replication_config_arn]}],
- WaiterConfig={"Delay": self.waiter_delay, "MaxAttempts":
self.waiter_max_attempts},
Review Comment:
> The only change for users is if they use the waiter
replication_terminal_status in their own operators
It sounds somewhat breaking change(?). If AWS don't categorized as such that
is very fine but I would recommend having a note in the changelog that user can
be aware of change in behaviour in case they have custom operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
