vincbeck commented on code in PR #46684:
URL: https://github.com/apache/airflow/pull/46684#discussion_r1953036522
##########
providers/amazon/src/airflow/providers/amazon/aws/operators/dms.py:
##########
@@ -493,10 +493,6 @@ def execute(self, context: Context) -> None:
Filters=[{"Name": "replication-config-arn", "Values":
[self.replication_config_arn]}],
WaiterConfig={"Delay": self.waiter_delay, "MaxAttempts":
self.waiter_max_attempts},
)
- self.hook.get_waiter("replication_deprovisioned").wait(
- Filters=[{"Name": "replication-config-arn", "Values":
[self.replication_config_arn]}],
- WaiterConfig={"Delay": self.waiter_delay, "MaxAttempts":
self.waiter_max_attempts},
Review Comment:
I really think this is not a breaking change but a bug fix. I extended the
waiter `replication_terminal_status ` so that it waits for 2 new status:
`created` and `deprovisioned` which are terminal states. There is no scenario
this code change can break user code but only fixes it. If a user, today, uses
the waiter `replication_terminal_status` and the replication is in either
`created` or `deprovisioned` state, the waiter will wait forever (until
timeout). With this change, the waiter will stop waiting if the replication
reaches either of these 2 states
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
