feluelle commented on a change in pull request #6232: [AIRFLOW-5582] AutoCommit
in jdbc is missing get_autocommit
URL: https://github.com/apache/airflow/pull/6232#discussion_r332257897
##########
File path: airflow/hooks/jdbc_hook.py
##########
@@ -57,3 +57,16 @@ def set_autocommit(self, conn, autocommit):
:return:
"""
conn.jconn.setAutoCommit(autocommit)
+
+ def get_autocommit(self, conn):
Review comment:
Please add a test so that `getAutoCommit` has been called when calling
`get_autocommit`. I know it might seems superflous but if the function gets
refactored (or changed) in the future we need to make sure to not break sth. /
breaking backwards compatiblity, etc. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
