feluelle commented on a change in pull request #6232: [AIRFLOW-5582] AutoCommit
in jdbc is missing get_autocommit
URL: https://github.com/apache/airflow/pull/6232#discussion_r332258183
##########
File path: airflow/hooks/jdbc_hook.py
##########
@@ -57,3 +57,16 @@ def set_autocommit(self, conn, autocommit):
:return:
"""
conn.jconn.setAutoCommit(autocommit)
+
+ def get_autocommit(self, conn):
Review comment:
Would also be nice if you could do it for the set_autocommit as well 👍 (see
[here](https://codecov.io/gh/apache/airflow/src/master/airflow/hooks/jdbc_hook.py#L59))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
