feluelle commented on a change in pull request #6232: [AIRFLOW-5582] AutoCommit
in jdbc is missing get_autocommit
URL: https://github.com/apache/airflow/pull/6232#discussion_r332258340
##########
File path: airflow/hooks/jdbc_hook.py
##########
@@ -57,3 +57,16 @@ def set_autocommit(self, conn, autocommit):
:return:
"""
conn.jconn.setAutoCommit(autocommit)
+
+ def get_autocommit(self, conn):
+ """
+ Get autocommit setting for the provided connection.
+ Return True if conn.autocommit is set to True.
+ Return False if conn.autocommit is not set or set to False
+
+ :param conn: The connection
Review comment:
Could you also add the type, please? Either via the docs `:type` or in the
function header directly to the arg `conn:`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
