jscheffl commented on PR #46820: URL: https://github.com/apache/airflow/pull/46820#issuecomment-2664129081
> It seems "::group::" is the documented approach though code also supports "##group##" . Do we need to support this? The syntax with `::` is the Github style. The variant with `##` is the way how ADO (MS AzureDevOps Pipelines) handle log grouping. As I was contributing this initially I wanted to make it compatible to both. If this is major complexity we can re-discuss. Else I'd propose to keep it. > I just used split string by "::group::" and capture the part after marker as name instead of regex to extract group name for simplicity but it can be made as a regex. I think this is OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
