jscheffl commented on code in PR #46820:
URL: https://github.com/apache/airflow/pull/46820#discussion_r1958803871
##########
airflow/ui/src/queries/useLogs.tsx:
##########
@@ -49,8 +50,46 @@ const parseLogs = ({ data }: ParseLogsProps) => {
return { data, warning };
}
- // eslint-disable-next-line react/no-array-index-key
- const parsedLines = lines.map((line, index) => <p key={index}>{line}</p>);
+ let startGroup = false;
+ let groupLines: Array<string> = [];
+ let groupName = "";
+
+ /* eslint-disable react/no-array-index-key */
+ const parsedLines = lines.map((line, index) => {
Review Comment:
This is a logic block which would be perfect to a unit test. Could you
extract this into a functions and add a test case? (I know we have a very low
coverage but this is an ideal candidate)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
