ashb commented on code in PR #47507:
URL: https://github.com/apache/airflow/pull/47507#discussion_r1985814758
##########
airflow/api_fastapi/core_api/routes/ui/config.py:
##########
@@ -61,6 +61,10 @@ def get_configs() -> ConfigResponse:
"audit_view_included_events": conf.get("webserver",
"audit_view_included_events", fallback=""),
"audit_view_excluded_events": conf.get("webserver",
"audit_view_excluded_events", fallback=""),
"test_connection": conf.get("core", "test_connection",
fallback="Disabled"),
+ "color_log_error_keywords": conf.get("logging",
"color_log_error_keywords", fallback="").split(","),
Review Comment:
1. there's a `conf.getlist` function
2. This is a UI setting, not a logging setting
3. Now we have structured logging (where the log level comes form the
"source" directly without needing to pase , I don't think we should be looking
for keywords.
4. I really really really REALLY don't want us to add more config options!
Also "Task succeded without error" would get highlighted as an error. Very
prone to false positives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
