jscheffl commented on code in PR #47507:
URL: https://github.com/apache/airflow/pull/47507#discussion_r1990127320
##########
airflow/api_fastapi/core_api/routes/ui/config.py:
##########
@@ -61,6 +61,10 @@ def get_configs() -> ConfigResponse:
"audit_view_included_events": conf.get("webserver",
"audit_view_included_events", fallback=""),
"audit_view_excluded_events": conf.get("webserver",
"audit_view_excluded_events", fallback=""),
"test_connection": conf.get("core", "test_connection",
fallback="Disabled"),
+ "color_log_error_keywords": conf.get("logging",
"color_log_error_keywords", fallback="").split(","),
Review Comment:
I am mostly with Ash. I had mostly false-positives with the highlighting so
far which ended-up that we disabled all keywords from default as users called
because being confused.
For Error/Warning I think the highlighting should be really oriented from
the log sub system and log level as we have structured data.
I'd be OK to have the highlighting with keyword, if not "Exception", "Error"
and "Warning" are used per default in config (as this would be over-lapping
with the log level). It might be use-ful for cases where custom words (other
than error...) are to be highlighted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
