tirkarthi commented on code in PR #47507:
URL: https://github.com/apache/airflow/pull/47507#discussion_r1985980806
##########
airflow/api_fastapi/core_api/routes/ui/config.py:
##########
@@ -61,6 +61,10 @@ def get_configs() -> ConfigResponse:
"audit_view_included_events": conf.get("webserver",
"audit_view_included_events", fallback=""),
"audit_view_excluded_events": conf.get("webserver",
"audit_view_excluded_events", fallback=""),
"test_connection": conf.get("core", "test_connection",
fallback="Disabled"),
+ "color_log_error_keywords": conf.get("logging",
"color_log_error_keywords", fallback="").split(","),
Review Comment:
This is not a new configuration. This was already present in Airflow 2.10.
This is a port of the implementation from the old UI to the new UI. We have use
cases where we show logs from external systems like Spark, HDFS etc that are
not structured from the triggerer as a log group like "::group::stdout". The
keywords help in highlighting the relevant line and improves debugging.
> Also "Task succeded without error" would get highlighted as an error. Very
prone to false positives.
Agreed, this is like a simple `ctrl+f` in the browser and has been more
useful than a hindrance,
Config docs :
https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#color-log-error-keywords
Airflow 2.10 implementation : https://github.com/apache/airflow/issues/37443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
