uranusjr commented on code in PR #47381:
URL: https://github.com/apache/airflow/pull/47381#discussion_r1986668103


##########
airflow/serialization/serialized_objects.py:
##########
@@ -1068,6 +1068,7 @@ def detect_task_dependencies(task: Operator) -> 
list[DagDependency]:
                 DagDependency(
                     source=task.dag_id,
                     target=getattr(task, "trigger_dag_id"),
+                    label=task.task_display_name or task.task_id,

Review Comment:
   I think `task_display_name` already handles the `or task_id` logic so this 
is not needed (the `or` never fires). Same for all calls below.
   
   ```suggestion
                       label=task.task_display_name,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to