jason810496 commented on code in PR #48040:
URL: https://github.com/apache/airflow/pull/48040#discussion_r2008643126
##########
dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py:
##########
@@ -982,6 +982,10 @@ def configure_cluster(
sys.exit(return_code)
+CLUSTER_FORWARDED_PORT = os.environ.get("CLUSTER_FORWARDED_PORT") or "8080"
+KUBERNETES_HOST_PORT = (os.environ.get("CLUSTER_HOST") or "localhost") + ":" +
CLUSTER_FORWARDED_PORT
Review Comment:
> I've decided to not go on the _get_kubernetes_port_numbers because it has
a specific different signature with multiple ports and has different defaults.
Since `_deploy_helm_chart` runs with `get_k8s_env` as its environment, and
`CLUSTER_FORWARDED_PORT` is passed to the Kubernetes test shell through
`new_env` in `get_k8s_env` rather than being set in the current shell,
I initially thought retrieving `CLUSTER_FORWARDED_PORT` from the current
shell might cause errors in getting the **correct** port. However, it turns out
the test runs fine.
That said, I believe fetching it from `_get_kubernetes_port_numbers` might
be more accurate.
> Or maybe it should be defined in breeze kubernetes utils too?
Yes, the Breeze scope I was referring to is
`dev/breeze/src/airflow_breeze/utils/kubernetes_utils.py`. I should have been
more specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
