insomnes commented on code in PR #48040:
URL: https://github.com/apache/airflow/pull/48040#discussion_r2007167734
##########
dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py:
##########
@@ -982,6 +982,10 @@ def configure_cluster(
sys.exit(return_code)
+CLUSTER_FORWARDED_PORT = os.environ.get("CLUSTER_FORWARDED_PORT") or "8080"
+KUBERNETES_HOST_PORT = (os.environ.get("CLUSTER_HOST") or "localhost") + ":" +
CLUSTER_FORWARDED_PORT
Review Comment:
I've decided to not go on the `_get_kubernetes_port_numbers` because it has
a specific different signature with multiple ports and has different defaults.
The new helper function `_get_airflow_api_host_with_forwarded_port`
encapsulates env vars getting logic. I hope this helps too. Or maybe it should
be defined in breeze kubernetes utils too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
