insomnes commented on code in PR #48040:
URL: https://github.com/apache/airflow/pull/48040#discussion_r2008910849
##########
dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py:
##########
@@ -982,6 +982,10 @@ def configure_cluster(
sys.exit(return_code)
+CLUSTER_FORWARDED_PORT = os.environ.get("CLUSTER_FORWARDED_PORT") or "8080"
+KUBERNETES_HOST_PORT = (os.environ.get("CLUSTER_HOST") or "localhost") + ":" +
CLUSTER_FORWARDED_PORT
Review Comment:
> I initially thought retrieving CLUSTER_FORWARDED_PORT from the current
shell might cause errors in getting the correct port. However, it turns out the
test runs fine.
It's set by breeze within running test helpers, but yeah I can agree with:
>That said, I believe fetching it from _get_kubernetes_port_numbers might be
more accurate.
So I used it and also added a warning in case of a non-existing kind config,
I didn't change `0, 0` return but found it a bit strange. Maybe there is some
case for it during cluster URLs printing for status check, so I left it as is.
I've also set the host in the URL to `localhost` because it's not detected
or set anywhere and in all URLs and status checks literal `localhost` is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
