amoghrajesh opened a new pull request, #48610:
URL: https://github.com/apache/airflow/pull/48610
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: https://github.com/apache/airflow/issues/48590
We have hardcoded certain configs for supervisor and for worker sdk API
client. Allowing these options to be configurable will allow for more
flexibility.
Introducing these changes under "workers" section in config.yml that was
added earlier for #48446.
## Testing
- Dag doesnt really matter here, I am testing two scenarios with celery
worker so that its a different host where config is loaded on.
Default options:
Running this:
```
for param in "workers task_instance_min_heartbeat_interval" \
"workers task_instance_max_failed_heartbeats" \
"workers execution_api_retries" \
"workers execution_api_retry_wait_min" \
"workers execution_api_retry_wait_max" \
"scheduler task_instance_heartbeat_timeout"
do
echo "Config: $param"
airflow config get-value $param
echo "===="
done
```
```
Config: workers task_instance_min_heartbeat_interval
5
====
Config: workers task_instance_max_failed_heartbeats
3
====
Config: workers execution_api_retries
5
====
Config: workers execution_api_retry_wait_min
1.0
====
Config: workers execution_api_retry_wait_max
90.0
====
Config: scheduler task_instance_heartbeat_timeout
300
====
```
Overriding with these environment variables.
```
export AIRFLOW__WORKERS__TASK_INSTANCE_MIN_HEARTBEAT_INTERVAL="10"
export AIRFLOW__WORKERS__TASK_INSTANCE_MAX_FAILED_HEARTBEATS="5"
export AIRFLOW__WORKERS__EXECUTION_API_RETRIES="4"
export AIRFLOW__WORKERS__EXECUTION_API_RETRY_WAIT_MIN="2.0"
export AIRFLOW__WORKERS__EXECUTION_API_RETRY_WAIT_MAX="50.0"
export AIRFLOW__SCHEDULER__TASK_INSTANCE_HEARTBEAT_TIMEOUT="90"
```
Ran the same script from above. Works as expected.
```
Config: workers task_instance_min_heartbeat_interval
10
====
Config: workers task_instance_max_failed_heartbeats
5
====
Config: workers execution_api_retries
4
====
Config: workers execution_api_retry_wait_min
2.0
====
Config: workers execution_api_retry_wait_max
50.0
====
Config: scheduler task_instance_heartbeat_timeout
90
====
```
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
