amoghrajesh commented on code in PR #48610:
URL: https://github.com/apache/airflow/pull/48610#discussion_r2022594942
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -109,13 +110,13 @@
log: FilteringBoundLogger = structlog.get_logger(logger_name="supervisor")
-# TODO: Pull this from config
-# (previously `[scheduler] task_instance_heartbeat_sec` with the following as
fallback if it is 0:
-# `[scheduler] task_instance_heartbeat_timeout`)
-HEARTBEAT_TIMEOUT: int = 30
+HEARTBEAT_TIMEOUT: int = conf.getint("scheduler",
"task_instance_heartbeat_timeout")
# Don't heartbeat more often than this
-MIN_HEARTBEAT_INTERVAL: int = 5
-MAX_FAILED_HEARTBEATS: int = 3
+MIN_HEARTBEAT_INTERVAL: int = conf.getint("workers",
"task_instance_min_heartbeat_interval")
+MAX_FAILED_HEARTBEATS: int = conf.getint("workers",
"task_instance_max_failed_heartbeats")
+
Review Comment:
Alrighty let me do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
