ihnokim commented on PR #49433: URL: https://github.com/apache/airflow/pull/49433#issuecomment-2825943814
@kaxil @potiuk I respect your opinions, but I believe this might add to the confusion for Helm chart users. According to what you’re saying, setting the ```AIRFLOW__CORE__EXECUTOR``` value inside a pod becomes essentially meaningless. If that's the case, are you suggesting that users (and this PR) should completely remove this value instead of overriding it? Personally, as @o-nikolas mentioned, I believe that configuration values managed by Airflow should be applied consistently across all components. As noted in issue #48667 and confirmed through testing, even when a pod is launched using the KubernetesExecutor, the task still behaves as if it's executed with the LocalExecutor, regardless of what value is passed to ```AIRFLOW__CORE__EXECUTOR```. The problem arises during the validation phase because Airflow’s validation logic is hardcoded to expect LocalExecutor, rather than referencing the global configuration. In other words, the validation logic is assuming that a consistent global configuration is in place, just as @o-nikolas pointed out. To summarize: updating this PR to follow the global configuration instead of using a hardcoded value doesn't break actual task execution. It simply ensures that the validation logic behaves as expected. Even after this PR is merged, Helm chart users can still freely override ```AIRFLOW__CORE__EXECUTOR``` if they want. The default value is just being changed to improve out-of-the-box usability, reducing the need for manual tweaks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
