potiuk commented on code in PR #49433:
URL: https://github.com/apache/airflow/pull/49433#discussion_r2056801353
##########
chart/files/pod-template-file.kubernetes-helm-yaml:
##########
@@ -95,7 +95,7 @@ spec:
- envFrom: {{- include "custom_airflow_environment_from" . | default "\n
[]" | indent 6 }}
env:
- name: AIRFLOW__CORE__EXECUTOR
- value: LocalExecutor
+ value: {{ .Values.executor | quote }}
Review Comment:
> Isn't this now going to pass `kubernetes_executor` inside the pod
unconditionally when using KubernetesExecutor??
>
> Double verifying -- Have you tested the changes thoroughly?
Right. I accidentally approved it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
