bugraoz93 commented on code in PR #51850:
URL: https://github.com/apache/airflow/pull/51850#discussion_r2153188265
##########
airflow-core/src/airflow/api_fastapi/core_api/services/public/task_instances.py:
##########
@@ -261,10 +261,15 @@ def handle_bulk_update(
results.errors.append({"error": f"{e.detail}", "status_code":
e.status_code})
def handle_bulk_delete(
- self, action: BulkDeleteAction[BulkTaskInstanceBody], results:
BulkActionResponse
+ self,
+ action: BulkDeleteActionWithEntity[BulkTaskInstanceBody], # type:
ignore
Review Comment:
Let's keep the current behaviour and add this as an extra action. This is a
breaking change which makes this endpoint not backwards compatible. Maybe we
can define a new action `BulkAction.DELETE_WITH_ENTITY` or something, and
include an additional method in the service. Then we can call that method in
the same route as a different action. This way, we can easily extend the bulk
actions per use case and make it backward compatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
