pierrejeambrun commented on code in PR #51850:
URL: https://github.com/apache/airflow/pull/51850#discussion_r2159375241
##########
airflow-ctl/src/airflowctl/api/datamodels/generated.py:
##########
@@ -1709,7 +1763,12 @@ class BulkBodyVariableBody(BaseModel):
extra="forbid",
)
actions: Annotated[
- list[BulkCreateActionVariableBody | BulkUpdateActionVariableBody |
BulkDeleteActionVariableBody],
+ list[
+ BulkCreateActionVariableBody
+ | BulkUpdateActionVariableBody
+ | BulkDeleteActionVariableBody
+ | BulkDeleteWithEntityActionVariableBody
Review Comment:
`BulkDeleteWithEntityActionVariableBody`
I don't think we need a separate action. We already have a
`handle_bulk_delete` that can handle a `BulkTaskInstanceBody` that convey the
Map index information.
I think we just need the serializer for delete entities to take either
`list[str | BulkTaskInstanceBody]` instead of the current `list[str]`. In
addition this will allow to pass a mixture of entities: ["some_id", {"task_id":
"something", "map_index": -1}] also maybe if the map_index is not specified,
instead of filling it with `-1` that could mean `all mapped indexes`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
