guan404ming commented on code in PR #51850:
URL: https://github.com/apache/airflow/pull/51850#discussion_r2153927421
##########
airflow-core/src/airflow/api_fastapi/core_api/services/public/task_instances.py:
##########
@@ -261,10 +261,15 @@ def handle_bulk_update(
results.errors.append({"error": f"{e.detail}", "status_code":
e.status_code})
def handle_bulk_delete(
- self, action: BulkDeleteAction[BulkTaskInstanceBody], results:
BulkActionResponse
+ self,
+ action: BulkDeleteActionWithEntity[BulkTaskInstanceBody], # type:
ignore
Review Comment:
Great suggestion! I would try implement it as a new `action` to make it
backward compatiable. Thanks!
##########
airflow-core/src/airflow/api_fastapi/core_api/services/public/task_instances.py:
##########
@@ -261,10 +261,15 @@ def handle_bulk_update(
results.errors.append({"error": f"{e.detail}", "status_code":
e.status_code})
def handle_bulk_delete(
- self, action: BulkDeleteAction[BulkTaskInstanceBody], results:
BulkActionResponse
+ self,
+ action: BulkDeleteActionWithEntity[BulkTaskInstanceBody], # type:
ignore
Review Comment:
Great suggestion! I would try implement it as a new `action` to make it
backward compatible. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
