jscheffl commented on code in PR #51792:
URL: https://github.com/apache/airflow/pull/51792#discussion_r2173320264
##########
chart/values.schema.json:
##########
@@ -463,6 +463,21 @@
"type": "boolean",
"default": false
},
+ "cacheSize": {
+ "description": "Add cache size for your statsD
deployment.",
+ "type": "integer",
+ "default": true
Review Comment:
As the value is of type int I assume the default should be numeric. in the
values.yaml you have 1000.
```suggestion
"default": 1000
```
##########
chart/values.schema.json:
##########
@@ -463,6 +463,21 @@
"type": "boolean",
"default": false
},
+ "cacheSize": {
+ "description": "Add cache size for your statsD
deployment.",
+ "type": "integer",
+ "default": true
+ },
+ "cacheType": {
+ "description": "Add cache type for your statsD
deployment (lru/random).",
+ "type": "string",
+ "default": true
Review Comment:
Same here, according to change in values.yaml should be:
```suggestion
"default": "lru"
```
##########
chart/values.schema.json:
##########
@@ -463,6 +463,21 @@
"type": "boolean",
"default": false
},
+ "cacheSize": {
+ "description": "Add cache size for your statsD
deployment.",
+ "type": "integer",
+ "default": true
+ },
+ "cacheType": {
+ "description": "Add cache type for your statsD
deployment (lru/random).",
+ "type": "string",
+ "default": true
+ },
+ "ttl": {
+ "description": "Configure Time TO Live time for
StatsD Metrics.",
+ "type": "string",
+ "default": true
Review Comment:
```suggestion
"default": "0s"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
