jedcunningham commented on code in PR #51792:
URL: https://github.com/apache/airflow/pull/51792#discussion_r2183462994
##########
chart/values.yaml:
##########
@@ -272,6 +272,36 @@ ingress:
# Enable web ingress resource
enabled: false
+ # If you ever need to fully override the entire args list, you can
+ # supply your own array here; if set, all below flag-specific values
+ # (mappingConfig, cacheSize, cacheType, ttl) are ignored.
+ # args:
+ # - "--statsd.cache-size=500"
+ # - "--statsd.cache-type=random"
+ # - "--ttl=10m"
+ # -------------------------------------------------------------------
+
+ # Path in the container to the mapping config file.
+
+ # Maximum number of metric‐mapping entries to keep in cache.
+ # When you send more distinct metric names than this, older entries
+ # will be evicted according to cacheType.
+ # Default: 1000
+ cacheSize: 1000
Review Comment:
Is this big enough? It feels pretty small - airflow generates a lot of
metrics in the real world.
##########
chart/values.schema.json:
##########
@@ -463,6 +463,21 @@
"type": "boolean",
"default": false
},
+ "cacheSize": {
+ "description": "Add cache size for your statsD
deployment.",
Review Comment:
Let's be more verbose in this as well - some users explore values via
artifacthub which uses this description. What you have in values.yaml is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
