jscheffl commented on code in PR #51792:
URL: https://github.com/apache/airflow/pull/51792#discussion_r2175767910
##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -103,6 +103,9 @@ spec:
{{- else}}
args:
- "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"
+ - "--statsd.cache-size={{ .Values.statsd.cacheSize }}"
+ - "--statsd.cache-type={{ .Values.statsd.cacheType }}"
+ - "--ttl={{ .Values.statsd.ttl }}"
Review Comment:
On my second pass-review. If `.Values.statsd.args` is defined this basically
means the `cacheSize`/`cacheType` and `ttl` parameters are ignored.
Can you at least add this to the docs or is there a way to append the
parameters to the args as well (merge them)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
