prakass1 commented on code in PR #53358:
URL: https://github.com/apache/airflow/pull/53358#discussion_r2210965789
##########
chart/templates/dag-processor/dag-processor-deployment.yaml:
##########
@@ -74,6 +77,9 @@ spec:
{{- with .Values.labels }}
{{- toYaml . | nindent 8 }}
{{- end }}
+ {{- with .Values.dagProcessor.labels }}
Review Comment:
spec/template/metadata which has the component for dag-processor will then
include both the .Values.labels and your change .Values.dagProcessor.labels.
However, if there is conflict with the label then it will not override. For
this purpose, if you have a look at api-server deployment spec again at
https://github.com/apache/airflow/blob/main/chart/templates/api-server/api-server-deployment.yaml#L81C1-L83C19
you see mustMerge is added to handle the case of conflict where the
.Values.labels will override ones from .Values.dagProcessor.labels. Could you
please add them exactly as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
