sjyangkevin commented on code in PR #53690: URL: https://github.com/apache/airflow/pull/53690#discussion_r2234566254
########## airflow-core/tests/unit/serialization/test_serde.py: ########## Review Comment: The test case `test_serializers_importable_and_str` is refactored to be parameterized on serializers. The logic that loads serializers from modules are moved into `generate_serializers_importable_and_str_test_cases`. This function generate all the test cases (the input and the expected output) to test if a serializer is importable. 1. It creates a single test case for each serializer defined in the module. 2. It allows us to mark the `numpy.bool` as expected failure (i.e., `xfail`) in pytest outcomes when the NumPy version in breeze environment is 1.x. The failure reason is documented in the `xfail` message. 3. If the NumPy version in breeze environemnt is 2.x, the test case for `numpy.bool` will pass. Please let me know if this approach is reasonable. Also, I would appreciate if you could provide some feedback on the test implementation (e.g., the invocation of a function in pytest.mark.parameterize to generate test case). Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
