sjyangkevin commented on code in PR #53690:
URL: https://github.com/apache/airflow/pull/53690#discussion_r2238373667
##########
airflow-core/tests/unit/serialization/test_serde.py:
##########
@@ -61,6 +63,49 @@ def recalculate_patterns():
_match_regexp.cache_clear()
+def generate_serializers_importable_and_str_test_cases():
Review Comment:
>Note that no other code is executed after the
[pytest.xfail()](https://docs.pytest.org/en/stable/reference/reference.html#pytest.xfail)
call, differently from the marker. That’s because it is implemented internally
by raising a known exception.
https://docs.pytest.org/en/stable/how-to/skipping.html#xfail-mark-test-functions-as-expected-to-fail
https://github.com/apache/airflow/pull/53690/commits/5735f6b4aa7efd83113089a87a553c663d6e1f4a
In the above commit, I mark a test as `XFAIL` from within the test. Suppose
the modules are loading as follow:
np.bool_
np.bool
kubernetes.client.models.v1_pod.V1Pod
datetime.date
...
If the test is marked as `XFAIL` from within the test while loading
`np.bool`. The test will not continue to check for the import for
`kubernetes.client.models.v1_pod.V1Pod` and `datetime.date`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
