sjyangkevin commented on code in PR #53690:
URL: https://github.com/apache/airflow/pull/53690#discussion_r2238331672
##########
airflow-core/tests/unit/serialization/test_serde.py:
##########
@@ -61,6 +63,49 @@ def recalculate_patterns():
_match_regexp.cache_clear()
+def generate_serializers_importable_and_str_test_cases():
Review Comment:
Thanks for the feedback. I would like to elaborate more about the thoughts
behind this implementation. Another approach to achieve it may be hard-coding
all the values in the parameterization list. In the case of new serializers are
added, we can also update the test case manually.
From another perspective, I think the intention may be to simulate the
following serializer loading (from what I understand, but may be wrong).
In the original implementation, it is a bit challenging to mark the loading
of `np.bool` as an expected failure when the installed numpy version is 1.x,
since executing `pytest.xfail` will interrupt the execution of the test.
https://github.com/apache/airflow/blob/0cd0ff0872cea4dffa088a88b54001d157de6e8e/airflow-core/src/airflow/serialization/serde.py#L361-L376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
