guan404ming commented on PR #51667: URL: https://github.com/apache/airflow/pull/51667#issuecomment-3189678486
## Fixed - the grid axes lines in dark mode should be fixed - selected color also should be the same as the grid view - we need a minimum width for tasks - We should only allow the grid view toggle button to show when the user has a dag run or task instance - The translation seems broken from my end - With one task the row height is not the same as the grid view <img width="810" height="353" alt="image" src="https://github.com/user-attachments/assets/28f3493f-c5b5-4b5f-a5f5-f4ed2c911781"; /> <img width="815" height="307" alt="image" src="https://github.com/user-attachments/assets/836e814b-a5fb-48cd-bf2d-69f5ea62bbfe"; /> <img width="847" height="510" alt="image" src="https://github.com/user-attachments/assets/c21ccdf0-bdb2-4a99-8bb7-6984eb477b55"; /> ## Need Confirmed - We should try to prevent the graph from completely rerendering when changing selection between tasks on the same dag run → I have updated the component to use `useMemo`, but switching the selection from a group task to an individual task still triggers a re-render, as these are treated as two different pages. - The spacing between the task name, the grid, and the gap between the grid and the graph views appears inconsistent → I am not sure if the update shown in the screenshot has resolved this issue. Please let me know if I have misunderstood or overlooked anything. - We are missing the “crosshairs” hover effect → Since the Gantt chart is rendered in a `Canvas`, I have not yet found an effective way to synchronize the hover state between the Grid and the Gantt. I would keep investigate about this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
