guan404ming commented on code in PR #51667:
URL: https://github.com/apache/airflow/pull/51667#discussion_r2278293877
##########
airflow-core/src/airflow/ui/src/layouts/Details/PanelButtons.tsx:
##########
@@ -72,10 +78,19 @@ const deps = ["all", "immediate", "tasks"];
type Dependency = (typeof deps)[number];
-export const PanelButtons = ({ dagView, limit, panelGroupRef, setDagView,
setLimit }: Props) => {
+export const PanelButtons = ({
+ dagView,
+ limit,
+ panelGroupRef,
+ setDagView,
+ setLimit,
+ setShowGantt,
+ showGantt,
+}: Props) => {
const { t: translate } = useTranslation(["components", "dag"]);
- const { dagId = "" } = useParams();
+ const { dagId = "", runId, taskId } = useParams();
const { fitView } = useReactFlow();
+ const shouldShowToggleButtons = Boolean(runId ?? taskId);
Review Comment:
Yes, it should be `Boolean(runId)`. Let me update it.
> In the future we can make a custom /gantt endpoint to generate a
box-whisker plot to show trends across runs.
That is a cool idea, but I'm not sure if there is still place to show
box-whisker. We could try and iterate the chart in the future!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
