guan404ming commented on code in PR #51667:
URL: https://github.com/apache/airflow/pull/51667#discussion_r2285510004
##########
airflow-core/src/airflow/ui/src/layouts/Details/DetailsLayout.tsx:
##########
@@ -110,16 +113,30 @@ export const DetailsLayout = ({ children, error,
isLoading, tabs }: Props) => {
key={`${dagView}-${direction}`}
ref={panelGroupRef}
>
- <Panel defaultSize={dagView === "graph" ? 70 : 20} id="main-panel"
minSize={6} order={1}>
+ <Panel
+ defaultSize={dagView === "graph" ? 70 : 20}
+ id="main-panel"
+ minSize={showGantt && dagView === "grid" ? 60 : 20}
Review Comment:
> We also need a runId check here. The min size doesn't make sense if you
dont have a runId selected.
Thanks for catching this.
> Also, I think its ok if these values are ? 30 : 6 instead. The gantt chart
looks like it can work with a minW of 150px instead of 500px
Updated as well. It will feel a little crowded visually on laptop, but I
think that’s acceptable for not taking lots of horizontal space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
