Lee-W commented on PR #53907:
URL: https://github.com/apache/airflow/pull/53907#issuecomment-3194819612
> At the very least, the link should be tied to the specific TI try (i.e the
TI.id UUID value) not the dag_id,run_id,task_id,map_index, otherwise the link
from one try could be mistakenly used on the wrong try.
To meet the frontend's needs. I last heard that we don’t have the `ti_id`
from the frontend.
We can either call the "get task instance" endpoint to retrieve the ID and
then make a subsequent API call, or we could choose not to support this from
the frontend. Additionally, I noticed that none of our public API endpoints use
the `ti_id`.
> If we want a redirect we can probably do it without a token, just using
the UUID of the task instance -- `.../redirect/{ti_id}` etc.
> ...
> But mostly: Why do we need this?
as stated in
https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-90+Human+in+the+loop
```
* An URL endpoint is provided that can be used to provide a prepared link
that can be shared (utility to generate included in provider to automate
creation of notifications)
* Directly opens and re-directs to the dialog with details
* Directly trigger one action as a single-click (e.g. single click on a
link in an email to approve) - assuming user is logged-in before
* Security first! This would need to be explicitly enabled in
configuration and a token would be added when generating to ensure CSRF is not
made by artificial URLs. URLs would need to be generated by the utility before
distribution.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
