Lee-W commented on code in PR #53907: URL: https://github.com/apache/airflow/pull/53907#discussion_r2281104549
########## airflow-core/src/airflow/api_fastapi/core_api/datamodels/hitl_shared_links.py: ########## @@ -0,0 +1,54 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from datetime import datetime +from typing import Any, Literal + +from pydantic import BaseModel, Field, HttpUrl + + +class GenerateHITLSharedLinkRequest(BaseModel): + """Schema for generating a Human-in-the-loop shared link.""" + + link_type: Literal["redirect", "respond"] = Field( + description=( + "Type of link to generate: 'redirect' for redirecting to corresponding page or " + "'respond' for respond directly." + ), + ) Review Comment: There will be another link like `/redirect?chosen_options=...¶ms_input=...` that redirects to the that page with predefined content but without responding --- I think this is the best way to achieve what's stated in https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-90+Human+in+the+loop > Directly trigger one action as a single-click (e.g. single click on a link in an email to approve) - assuming user is logged-in before We can surely make it a GET instead, but it sounds risky to me. User trying to GET something and the result is updating something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
