ashb commented on PR #53907: URL: https://github.com/apache/airflow/pull/53907#issuecomment-3195595494
> To meet the frontend's needs. I last heard that we don’t have the `ti_id` from the frontend. Then lets change that. We control both ends, we can change it 😄 I also wonder if a lot of that could be done with query params and on the front end. `?option=Approve` or something like that pre-populates the form. i.e. nothing needed to store in the DB for that plan to work. Single click to approve in an email I don't think is safe -- for that to work I think it would need to be a GET request and having a GET mutate state seems like a poor idea. We could _maybe_ have a GET request that loads the page and then submits via JS, but that still feels like an error/risk-prone approach to me. A pure GET request that mutates the state runs the risk of some background process (be it the browser itself pre-fetching, or the MUA etc) hitting it and running the endpoint, so I think that is out to my mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
